fix(ivy): fix proliferation of provider overrides for modules #29571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
added
action: merge
alxhub
force-pushed
the
testbed/bug/provider-proliferation
branch
2 times, most recently
from
c5413e9
to
01c0da9
Compare
When an @NgModule is imported more than once in the testing module (for example it appears in the imports of more than one module, or if it's literally listed multiple times), then TestBed had a bug where the providers for the module would be overridden many times. This alone was problematic but would not break tests. However, the original value of the providers field of the ngInjectorDef was saved each time, and restored in the same order. Thus, if the provider array was [X], and overrides were applied twice, then the override array would become [X, X'] and then [X, X', X, X']. However, on the second override the state [X, X'] would be stored as original. The array would then be restored to [X] and then [X, X']. Each test, therefore, would continue to double the size of the providers array for the module, eventually exhausting the browser's memory. This commit adds a Set to track when overrides have been applied to a module and refrain from applying them more than once.
alxhub
force-pushed
the
testbed/bug/provider-proliferation
branch
from
01c0da9
to
d76d678
Compare
kara
approved these changes
Mar 28, 2019
kara
added
comp: ivy
and removed
action: presubmit
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…r#29571) When an @NgModule is imported more than once in the testing module (for example it appears in the imports of more than one module, or if it's literally listed multiple times), then TestBed had a bug where the providers for the module would be overridden many times. This alone was problematic but would not break tests. However, the original value of the providers field of the ngInjectorDef was saved each time, and restored in the same order. Thus, if the provider array was [X], and overrides were applied twice, then the override array would become [X, X'] and then [X, X', X, X']. However, on the second override the state [X, X'] would be stored as original. The array would then be restored to [X] and then [X, X']. Each test, therefore, would continue to double the size of the providers array for the module, eventually exhausting the browser's memory. This commit adds a Set to track when overrides have been applied to a module and refrain from applying them more than once. PR Close angular#29571
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an @NgModule is imported more than once in the testing module (for
example it appears in the imports of more than one module, or if it's
literally listed multiple times), then TestBed had a bug where the
providers for the module would be overridden many times.
This alone was problematic but would not break tests. However, the original
value of the providers field of the ngInjectorDef was saved each time, and
restored in the same order. Thus, if the provider array was [X], and
overrides were applied twice, then the override array would become
[X, X'] and then [X, X', X, X']. However, on the second override the state
[X, X'] would be stored as original. The array would then be restored to
[X] and then [X, X'].
Each test, therefore, would continue to double the size of the providers
array for the module, eventually exhausting the browser's memory.
This commit adds a Set to track when overrides have been applied to a module
and refrain from applying them more than once.